Restructure create app to make it easier to upgrade deps #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericanderson
commented
Jul 11, 2024
| `; | ||
| }, | ||
| }, | ||
| }), |
.vscode/settings.json
Outdated
| @@ -5,7 +5,7 @@ | |||
| "editor.defaultFormatter": "dprint.dprint" | |||
| }, | |||
| "[typescript]": { | |||
| "editor.defaultFormatter": "vscode.typescript-language-features" | |||
| "editor.defaultFormatter": "dprint.dprint" | |||
There was a problem hiding this comment.
I'm not sure how this got changed but its doing the wrong formatting until now.
| import * as fs from "node:fs/promises"; | ||
| import * as path from "node:path"; | ||
| import serialize from "serialize-javascript"; | ||
|
|
There was a problem hiding this comment.
Code gen for each @osdk/create-app.template.*/src/generatedNoCheck/
| @@ -79,16 +79,38 @@ export async function run( | |||
|
|
|||
| consola.info(`Copying files into project directory`); | |||
There was a problem hiding this comment.
Begin actual meat change for the template generation. Just writes from a map instead of cp from a directory.
| @@ -141,12 +142,49 @@ async function checkExamples( | |||
| `Found ${compareResult.differences} differences in ${exampleId} please generate examples again.`, | |||
| ); | |||
| consola.error(compareResult.diffSet?.filter(d => d.state !== "equal")); | |||
|
|
|||
There was a problem hiding this comment.
Output proper diffs when things don't match
ericanderson
force-pushed
the
ea.restructure-create-app
branch
from
792f719 to
acff9d6
Compare
ssanjay1
approved these changes
Jul 17, 2024
ericanderson
force-pushed
the
ea.restructure-create-app
branch
from
acff9d6 to
af052e0
Compare
ericanderson
force-pushed
the
ea.restructure-create-app
branch
from
af052e0 to
5b2ffc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Thankfully, the existence of the
examplesdirectory to validate the output of the generators means I was able to ensure this did not change the output!Note for reviewer:
@osdk/create-app.template.*folders are just:packages/create-app/templates/X->packages/create-app.template.X(except X changed slightly).templates/package.json.hbsfile and put them inpackage.jsonpackages/create-app/srcand the new package that has the codegenpackages/create-app.template-packager.